Function to generate random within specific range

[matteus]

Code: Select all

u16 randomNumberGenerator(u16 finishInt) {
    u16 x = 0;
    do {
        x = random();
    } while (x <= 0 || x > finishInt);
        return x - 1;
}

Is this the best way to be doing it?

u16 randomNumberGenerator(10) would give me random 1 to 10

[cero]

No, that's really wasteful, and can run infinite time. Hint: modulo operator.

[matteus]

Code: Select all

x = (random()%finishInt-1)+1;

Is this right?

[matteus]

P.S you've just helped me no end! I'm really grateful

[cero]

I would add a couple parenthesis (), otherwise the calculation order may not be what you expect.