Makefile

SGDK only sub forum

Moderator: Stef

Post Reply
twosixonetwo
Very interested
Posts: 58
Joined: Tue Feb 25, 2014 3:38 pm

Makefile

Post by twosixonetwo »

While cleaning up my random coding snippets and setting up some project-directories I looked through the makefile to make everything compile again and saw the following parts:

Code: Select all

out/sega.o: $(LIBSRC)/boot/sega.s out/rom_head.bin
$(MKDIR) -p out
$(CC) $(FLAGS) -c $(LIBSRC)/boot/sega.s -o $@
and

Code: Select all

out/rom_head.o: $(LIBSRC)/boot/rom_head.c
$(MKDIR) -p out
$(CC) $(FLAGS) -c $< -o $@
Wouldn't it be better to expect both files in SRC rather than LIBSRC? The rom_head file contains the name of the game, which is likely to be different for each project one is working on. The sega.s file contains the list of vectors, which are also likely to be different, at least if you're coding things where timing is critical...
Stef
Very interested
Posts: 3131
Joined: Thu Nov 30, 2006 9:46 pm
Location: France - Sevres
Contact:

Post by Stef »

Added an issue about it :
https://code.google.com/p/sgdk/issues/detail?id=25

Indeed that would be better to do that way :)
twosixonetwo
Very interested
Posts: 58
Joined: Tue Feb 25, 2014 3:38 pm

Post by twosixonetwo »

Thanks! I wasn't really sure about it, so I thought posting here would be a safer way to clear this than complaining on the bug tracker ;)
Stef
Very interested
Posts: 3131
Joined: Thu Nov 30, 2006 9:46 pm
Location: France - Sevres
Contact:

Post by Stef »

You're welcome, that is quite simple to fix and it makes more sense this way :) The change is already available on the SVN repository.
Post Reply