ROM Bugs after delete 1 line [SOLVED]

[cloudstrifer]

Hi, please help me, my rom not works correctly after I remove or comment 1 line.
My main.c have 7447 lines.

//SPR_setVisibility(lifes_p1, VISIBLE);

Works

Goof OLD - Working.rar

(233.25 KiB) Downloaded 368 times

After remove line not works

Goof New - Not working.zip

(255.69 KiB) Downloaded 320 times

Using "New rom" 2 enemies don't move, and after 1 minute game crashes.


Thank you!

[Stef]

I don't understand what you expect from us..
I tested both ROM, and both appears to work. You didn't tell us what is not working anymore in the new ROM.
Also you only provide the ROM so we cannot do anything from just :

Code: Select all

Hi, please help me, my rom not works correctly after I remove or comment 1 line.
My main.c have 7447 lines.

//SPR_setVisibility(lifes_p1, VISIBLE);

At least i can say this, your main file is 7447 lines.. that is definitely insane. Try to modularize and split your code in several file, you will never be able to maintain your code putting everything in a single file (well it's possible but terribly painful).

[cloudstrifer]

Thank you for reply.

Using "New rom" 2 enemies don't move, and after 1 minute game crashes.

I will solve the problem with my code, splitting and cleaning, I'm just writing code, but it became too big.

[cloudstrifer]

Sorry about wasting your time, but now it don't crashes anymore.

Maybe Im crazy

For now, I will investigate that issue.

Thank you!

[hotrodx]

(Running on an emulator)

I just noticed that when you first load up "Goof NEW.bin", the two sprites do not move. If you do a soft reset, they'd move. If you do a hard reset, they won't move again. So I'm guessing it has something to do with variable initialization failing to account soft resets.

EDIT: Or, some of the variables were used before being initialized, and was initialized AFTER the offending line. When you do a soft reset, it would have value now. But with a hard reset, it's uninitialized again.

[cloudstrifer]

(Running on an emulator)

I just noticed that when you first load up "Goof NEW.bin", the two sprites do not move. If you do a soft reset, they'd move. If you do a hard reset, they won't move again. So I'm guessing it has something to do with variable initialization failing to account soft resets.

EDIT: Or, some of the variables were used before being initialized, and was initialized AFTER the offending line. When you do a soft reset, it would have value now. But with a hard reset, it's uninitialized again.

I'm looking for mistakes.

Thank you.

[nemezes]

I don't understand what you expect from us..
I tested both ROM, and both appears to work. You didn't tell us what is not working anymore in the new ROM.
Also you only provide the ROM so we cannot do anything from just :

Code: Select all

Hi, please help me, my rom not works correctly after I remove or comment 1 line.
My main.c have 7447 lines.

//SPR_setVisibility(lifes_p1, VISIBLE);

At least i can say this, your main file is 7447 lines.. that is definitely insane. Try to modularize and split your code in several file, you will never be able to maintain your code putting everything in a single file (well it's possible but terribly painful).

I use everything in one file and the game works fine.

I get confused when working with several files.

[cloudstrifer]

I don't understand what you expect from us..
I tested both ROM, and both appears to work. You didn't tell us what is not working anymore in the new ROM.
Also you only provide the ROM so we cannot do anything from just :

Code: Select all

Hi, please help me, my rom not works correctly after I remove or comment 1 line.
My main.c have 7447 lines.

//SPR_setVisibility(lifes_p1, VISIBLE);

At least i can say this, your main file is 7447 lines.. that is definitely insane. Try to modularize and split your code in several file, you will never be able to maintain your code putting everything in a single file (well it's possible but terribly painful).

I use everything in one file and the game works fine.

I get confused when working with several files.

2 enemies are not moving on New rom.
Maybe its a not initialized variable.

[cloudstrifer]

Confirmed, variable initialization, now enemies only allowed to move after screen creation is complete.

Thank you!

[cloudstrifer]

I found another error, index out of bounds.
S8 array [6];
...
Array [6] = 0;

Thank you!