Page 1 of 1

Makefile

Posted: Wed Jul 30, 2014 11:45 am
by twosixonetwo
While cleaning up my random coding snippets and setting up some project-directories I looked through the makefile to make everything compile again and saw the following parts:

Code: Select all

out/sega.o: $(LIBSRC)/boot/sega.s out/rom_head.bin
$(MKDIR) -p out
$(CC) $(FLAGS) -c $(LIBSRC)/boot/sega.s -o $@
and

Code: Select all

out/rom_head.o: $(LIBSRC)/boot/rom_head.c
$(MKDIR) -p out
$(CC) $(FLAGS) -c $< -o $@
Wouldn't it be better to expect both files in SRC rather than LIBSRC? The rom_head file contains the name of the game, which is likely to be different for each project one is working on. The sega.s file contains the list of vectors, which are also likely to be different, at least if you're coding things where timing is critical...

Posted: Thu Jul 31, 2014 5:53 pm
by Stef
Added an issue about it :
https://code.google.com/p/sgdk/issues/detail?id=25

Indeed that would be better to do that way :)

Posted: Sat Aug 02, 2014 8:14 am
by twosixonetwo
Thanks! I wasn't really sure about it, so I thought posting here would be a safer way to clear this than complaining on the bug tracker ;)

Posted: Sat Aug 02, 2014 9:20 am
by Stef
You're welcome, that is quite simple to fix and it makes more sense this way :) The change is already available on the SVN repository.